Toolbar icon doesn't load?

[Josh]

Occasionally the editor will display a white square on one or more toolbar buttons. I'm not sure if this is a Win32 problem or a problem with the SVG rasterizer.

[reepblue]

Yep, this happened to me too a few times. 

[Josh]

The problem is related to the GDI image. The SVG rasterizer is working correctly:

[Josh]

I replace Lock/Unlock bits with SetPixel and it seems to work correctly. No idea why but it doesn't seem any slower this way.

#ifdef _WIN32
	shared_ptr<Gdiplus::Bitmap> Pixmap::GetBitmap()
	{
		if (bitmap) return bitmap;

		auto pixmap = As<Pixmap>();
		int format = PixelFormat32bppPARGB;
		int bpp = 4;
		switch (m_format)
		{
		case TEXTURE_BGRA:
			break;
		case TEXTURE_BGR:
			bpp = 3;
			format = PixelFormat24bppRGB;
			break;
		default:
			pixmap = Convert(TEXTURE_BGRA);
			if (pixmap == NULL) return NULL;
			break;
		}
		auto bitmap = std::make_shared<Gdiplus::Bitmap>(size.x, size.y, format);
		unsigned char pixel[4] = { 0,0,0,255 };
		Gdiplus::Color color;
		/*
		Gdiplus::BitmapData data;
		Gdiplus::Rect rect = Gdiplus::Rect(0, 0, size.x, size.y);		
		auto stat = bitmap->LockBits(&rect, Gdiplus::ImageLockMode::ImageLockModeWrite, format, &data);
		if (stat != Gdiplus::Status::Ok) return NULL;
		memcpy(data.Scan0, pixmap->pixels->Data(), pixmap->pixels->GetSize());
		stat = bitmap->UnlockBits(&data);
		if (stat != Gdiplus::Status::Ok) return NULL;
		*/
		uint32_t rgba;
		for (int x = 0; x < size.x; ++x)
		{
			for (int y = 0; y < size.y; ++y)
			{
				rgba = pixmap->ReadPixel(x, y);
				if (format == TEXTURE_BGRA) rgba = Rgba(Blue(rgba), Green(rgba), Red(rgba), Alpha(rgba));
				color.SetValue(rgba);
				bitmap->SetPixel(x, y, color);
			}
		}
		this->bitmap = bitmap;
		return bitmap;
	}
#endif

 

[Josh]

Scratch that, I can still produce the error in this build...curiouser and curiouser

[Josh]

This might be fixed now. Let me know if you see it again after downloading the current build.